[Autosave] Add localtex API support, fix cancer #372

Merged

starstormhun merged 1 commit from Autosave-localtex-support into master

2025-10-30 21:08:53 +00:00

starstormhun commented

2025-10-30 20:21:34 +00:00

(Migrated from github.com)

No description provided.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-30 21:05:46 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR removes unused package dependencies and adds new configuration options for texture save type overrides during autosaves. The changes modernize dependencies by updating IllusionModdingAPI packages to version 1.44.0 and removing unnecessary analyzers and ExtensibleSaveFormat packages.

Key changes:

Added texture save type override configuration for Maker and Studio autosaves
Updated IllusionModdingAPI packages from version 1.38.0 to 1.44.0
Removed unused Microsoft.Unity.Analyzers and ExtensibleSaveFormat packages

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Autosave.SBPR/SBPR.Autosave.csproj	Removed Microsoft.Unity.Analyzers package
src/Autosave.PH/PH.Autosave.csproj	Removed ExtensibleSaveFormat.PlayHome, Microsoft.Unity.Analyzers; updated PHAPI to 1.44.0
src/Autosave.PC/PC.Autosave.csproj	Removed Microsoft.Unity.Analyzers package
src/Autosave.KKS/KKS.Autosave.csproj	Removed ExtensibleSaveFormat.KoikatsuSunshine, Microsoft.Unity.Analyzers; updated KKSAPI to 1.44.0
src/Autosave.KK/KK.Autosave.csproj	Removed ExtensibleSaveFormat.Koikatu, Microsoft.Unity.Analyzers; updated KKAPI to 1.44.0
src/Autosave.HS2/HS2.Autosave.csproj	Removed ExtensibleSaveFormat.HoneySelect2, Microsoft.Unity.Analyzers; updated HS2API to 1.44.0
src/Autosave.HS/HS.Autosave.csproj	Removed Microsoft.Unity.Analyzers package
src/Autosave.EC/EC.Autosave.csproj	Removed ExtensibleSaveFormat.EmotionCreators, Microsoft.Unity.Analyzers; updated ECAPI to 1.44.0
src/Autosave.Core/Autosave.cs	Added texture save type override configuration and helper methods
src/Autosave.AI/AI.Autosave.csproj	Removed ExtensibleSaveFormat.AIGirl, Microsoft.Unity.Analyzers; updated AIAPI to 1.44.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull Request Overview This PR removes unused package dependencies and adds new configuration options for texture save type overrides during autosaves. The changes modernize dependencies by updating IllusionModdingAPI packages to version 1.44.0 and removing unnecessary analyzers and ExtensibleSaveFormat packages. Key changes: - Added texture save type override configuration for Maker and Studio autosaves - Updated IllusionModdingAPI packages from version 1.38.0 to 1.44.0 - Removed unused Microsoft.Unity.Analyzers and ExtensibleSaveFormat packages ### Reviewed Changes Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | src/Autosave.SBPR/SBPR.Autosave.csproj | Removed Microsoft.Unity.Analyzers package | | src/Autosave.PH/PH.Autosave.csproj | Removed ExtensibleSaveFormat.PlayHome, Microsoft.Unity.Analyzers; updated PHAPI to 1.44.0 | | src/Autosave.PC/PC.Autosave.csproj | Removed Microsoft.Unity.Analyzers package | | src/Autosave.KKS/KKS.Autosave.csproj | Removed ExtensibleSaveFormat.KoikatsuSunshine, Microsoft.Unity.Analyzers; updated KKSAPI to 1.44.0 | | src/Autosave.KK/KK.Autosave.csproj | Removed ExtensibleSaveFormat.Koikatu, Microsoft.Unity.Analyzers; updated KKAPI to 1.44.0 | | src/Autosave.HS2/HS2.Autosave.csproj | Removed ExtensibleSaveFormat.HoneySelect2, Microsoft.Unity.Analyzers; updated HS2API to 1.44.0 | | src/Autosave.HS/HS.Autosave.csproj | Removed Microsoft.Unity.Analyzers package | | src/Autosave.EC/EC.Autosave.csproj | Removed ExtensibleSaveFormat.EmotionCreators, Microsoft.Unity.Analyzers; updated ECAPI to 1.44.0 | | src/Autosave.Core/Autosave.cs | Added texture save type override configuration and helper methods | | src/Autosave.AI/AI.Autosave.csproj | Removed ExtensibleSaveFormat.AIGirl, Microsoft.Unity.Analyzers; updated AIAPI to 1.44.0 | </details> --- 💡 <a href="/IllusionMods/KK_Plugins/new/master/.github?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

src/Autosave.Core/Autosave.cs

The Join method usage is incorrect. Split(' ') returns a string[], but the Join method signature used here Join((x) => x, \"\") is not a valid extension method on arrays. This should use string.Join(\"\", _val.Split(' ')) instead to concatenate the split string parts.

            return (T)Enum.Parse(typeof(T), string.Join("", _val.Split(' ')), true);

The `Join` method usage is incorrect. `Split(' ')` returns a `string[]`, but the `Join` method signature used here `Join((x) => x, \"\")` is not a valid extension method on arrays. This should use `string.Join(\"\", _val.Split(' '))` instead to concatenate the split string parts. ```suggestion return (T)Enum.Parse(typeof(T), string.Join("", _val.Split(' ')), true); ```