WIP: Updating to a new clean dump #25
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
IllusionMods/AI-Girl-Translations!25
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "updating-dump"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Still a work in progress
@ -1,3 +1,6 @@//// Dumped for AI Girl v1.2.3 by Text Dump v1.4.4Can you leave these comments out? They will create a lot of unnecessary noise in the diffs and when parsing these files with other tools.
@ -1,3 +1,6 @@//// Dumped for AI Girl v1.2.3 by Text Dump v1.4.4It's vital to my workflow, and being able to support them from my end. They only change when I start from a clean dump or add new files (existing files would only get the new lines added in that case and I leave the header alone). In this case I started from a clean dump and re-applied everything because there were so many new items.
@ -1,3 +1,6 @@//// Dumped for AI Girl v1.2.3 by Text Dump v1.4.4They get cut out by most current translation/cleanup tools so there's a good chance they will disappear at a random point in the future. At this point it's workflow vs workflow. Also are these supposed to be removed after a file is translated?
@ -1,3 +1,6 @@//// Dumped for AI Girl v1.2.3 by Text Dump v1.4.4I'd really rather they weren't. I know they're stripped when the releases are made which is fine because the tree gets tagged at that point so it's easy enough to figure things out from there. Everyone has been good about keeping them until now, since I added them to TexDump. There's a history of translation notes in comments so I figured they were preserved by most everything anyhow.
@ -1,3 +1,6 @@//// Dumped for AI Girl v1.2.3 by Text Dump v1.4.4It's still unnecessary noise in the diffs on every update. It's not possible to see what actually changed because the diff is so massive.
@ -1,3 +1,6 @@//// Dumped for AI Girl v1.2.3 by Text Dump v1.4.4Normally they don't change ever once added once , as I said above. The previous dump was missing so much it was easier to take the clean dump and reapply the existing translations to it. Having these lines made things a lot easier for me to keep on top of things, but I take your point that for files otherwise unchanged it's muddying up the review, so I'll have to rework how I'm doing things. It'll take me a bit so I'll just close the review for now
Pull request closed