TranslationHelper - Add "Move first names to front" setting #10

2025-10-10T13:52:53Z

ManlyMarco commented

2025-10-10 13:52:53 +00:00

(Migrated from github.com)

No description provided.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-10 13:53:13 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

Adds a new configuration option to control the ordering of first and last names in the translation helper plugin. This allows users to choose between automatic language-based ordering, first name first, or last name first.

Added FirstNameOrder enum with Auto, FirstnameFirst, and LastnameFirst options
Implemented FirstNameFirst() method to determine name ordering based on configuration
Updated name translation hooks to use the configurable ordering

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tools/AC_TranslationHelper/TranslationHelperPlugin.cs	Added name ordering configuration and updated translation logic
tools/AC_TranslationHelper/Extensions.cs	Cleaned up namespace and removed unused imports

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview Adds a new configuration option to control the ordering of first and last names in the translation helper plugin. This allows users to choose between automatic language-based ordering, first name first, or last name first. - Added FirstNameOrder enum with Auto, FirstnameFirst, and LastnameFirst options - Implemented FirstNameFirst() method to determine name ordering based on configuration - Updated name translation hooks to use the configurable ordering ### Reviewed Changes Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments. | File | Description | | ---- | ----------- | | tools/AC_TranslationHelper/TranslationHelperPlugin.cs | Added name ordering configuration and updated translation logic | | tools/AC_TranslationHelper/Extensions.cs | Cleaned up namespace and removed unused imports | --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/IllusionMods/Aicomi-Translation/new/main/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

tools/AC_TranslationHelper/TranslationHelperPlugin.cs

					
				@ -85,7 +110,7 @@ namespace AC_TranslationHelper

				            [HarmonyPatch(typeof(HumanDataParameter), nameof(HumanDataParameter.fullname), MethodType.Getter)]

[nitpick] Extra blank line should be removed to maintain consistent code formatting.

[nitpick] Extra blank line should be removed to maintain consistent code formatting. ```suggestion ```

tools/AC_TranslationHelper/TranslationHelperPlugin.cs

					
				@ -110,3 +135,3 @@

				                tmp.text = TryTranslateName(data.Parameter.firstname, data.Parameter.lastname, '\n');

				                tmp.text = FirstNameFirst() ? TryTranslateName(data.Parameter.firstname, data.Parameter.lastname, '\n') : TryTranslateName(data.Parameter.lastname, data.Parameter.firstname, '\n');

				            }

Missing using directive for StringComparison. Add 'using System;' to the imports.

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

IllusionMods/Aicomi-Translation!10

				`@ -85,7 +110,7 @@ namespace AC_TranslationHelper`
				`[HarmonyPatch(typeof(HumanDataParameter), nameof(HumanDataParameter.fullname), MethodType.Getter)]`

Rows
Columns