Fix exception if .First() would find nothing #23

Merged

Kokaiinum merged 2 commits from master into master

2022-01-14 04:19:54 +00:00

Kokaiinum commented

2022-01-13 04:16:11 +00:00

(Migrated from github.com)

I'm not entirely sure if this is a situation that should ever be able to happen? But I've seen some logs where it did, and when it happens it totally crashes the loading process.

ManlyMarco commented

2022-01-13 10:27:19 +00:00

(Migrated from github.com)

It should at least log a warning if not finding one is unexpected. If the animation won't load properly if this is wrong then skipping the animation with a warning would be better.

IDontHaveIdea commented

2022-01-13 20:08:55 +00:00

(Migrated from github.com)

If the manifest has wrong NeckDonorId this certainly can fail.

For a wrong DonorPoseId it has to skip like it does and logs a waring. The animation should load properly not with an intended different NeckDonor. A warning will catch this.

Can't think of any other reason for failure.

If you can verify the validity of the search and log a warning with the NeckDonorId when it fails it would be better.

If the manifest has wrong NeckDonorId this certainly can fail. For a wrong DonorPoseId it has to skip like it does and logs a waring. The animation should load properly not with an intended different NeckDonor. A warning will catch this. Can't think of any other reason for failure. If you can verify the validity of the search and log a warning with the NeckDonorId when it fails it would be better.

IDontHaveIdea (Migrated from github.com) approved these changes

2022-01-14 04:19:19 +00:00

IDontHaveIdea (Migrated from github.com) left a comment

Looks ok.