WIP: [Screencap] Rudimentary Profiles #208

Draft

Njaecha wants to merge 2 commits from Njaecha/Screencap_Profiles into master

Njaecha commented

2024-09-30 11:06:33 +00:00

(Migrated from github.com)

Adds rudimentary support for additional resolution presets, which can be bound to additional hotkey.
They are not a hotkey to change the settings, but rather additional settings, independent of the normal settings.
Because of that they do not benefit from recent improvements like the guide lines.

Adds rudimentary support for additional resolution presets, which can be bound to additional hotkey. They are not a hotkey to change the settings, but rather additional settings, _independent of the normal settings_. Because of that they **do not benefit** from recent improvements like the guide lines.

Njaecha commented

2024-09-30 11:08:15 +00:00

(Migrated from github.com)

Looks like this in the settings:

Looks like this in the settings: ![image](https://github.com/user-attachments/assets/eb7992ee-df33-4b41-aa83-3c9fd215518e)

ManlyMarco (Migrated from github.com) reviewed

2024-09-30 20:02:55 +00:00

src/Core_Screencap/Core.ScreenshotManager.cs

Wouldn't it make more sense to include number of the preset in the category name? e.g. [Custom Hotkey 1]

Here's how I implemented something similar, a bit less user friendly though.

Wouldn't it make more sense to include number of the preset in the category name? e.g. `[Custom Hotkey 1]` [Here's](https://github.com/BepInEx/BepInEx.Utility.IL2CPP/blob/main/Patch_ByteFiddlerIL2CPP_Net6/ByteFiddlerPatcher.cs#L22-L45) how I implemented something similar, a bit less user friendly though.

ManlyMarco (Migrated from github.com) reviewed

2024-09-30 20:06:34 +00:00

src/Core_Screencap/Core.ScreenshotManager.cs

I'd rather make a struct to hold all these config entries in a single list.

Njaecha (Migrated from github.com) reviewed

2024-10-01 08:02:16 +00:00

src/Core_Screencap/Core.ScreenshotManager.cs

Understandable, I can fix that 😄

This pull request has changes conflicting with the target branch.

src/Core_Screencap/Core.ScreenshotManager.cs

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin Njaecha/Screencap_Profiles:Njaecha/Screencap_Profiles

git switch Njaecha/Screencap_Profiles

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master

git merge --no-ff Njaecha/Screencap_Profiles

git switch Njaecha/Screencap_Profiles

git rebase master

git switch master

git merge --ff-only Njaecha/Screencap_Profiles

git switch Njaecha/Screencap_Profiles

git rebase master

git switch master

git merge --no-ff Njaecha/Screencap_Profiles

git switch master

git merge --squash Njaecha/Screencap_Profiles