[US] Add configurable camera speed #1

2021-12-28T04:59:55Z

kkykkykky commented

2021-12-28 04:59:55 +00:00

(Migrated from github.com)

A long time ago Joan accepted this small change I proposed, but, unfortunately, he never got around to merging it into his code so it was never released.

As you know, things in AI and HS2 are 10 times bigger, so the camera movement speed boost that UsefulStuff offers is not very sufficient. This change allows users to customize the speed to their liking. I've set the default factor for AI and HS2 to 10.

I've tested it in AI, HS2, and KKS. The KK I have is too old, so I'm not able to test.

Thanks for forking HSPlugins!

A long time ago Joan accepted this small change I proposed, but, unfortunately, he never got around to merging it into his code so it was never released. As you know, things in AI and HS2 are 10 times bigger, so the camera movement speed boost that UsefulStuff offers is not very sufficient. This change allows users to customize the speed to their liking. I've set the default factor for AI and HS2 to 10. I've tested it in AI, HS2, and KKS. The KK I have is too old, so I'm not able to test. Thanks for forking HSPlugins!

ManlyMarco (Migrated from github.com) reviewed

2021-12-28 12:33:13 +00:00

UsefulStuff.Core/Features/CameraShortcuts.cs

					
				@ -63,3 +60,1 @@

				                    return Input.GetAxis(axis) / 6f;

				                if (Input.GetKey(KeyCode.LeftShift))

				                    return Input.GetAxis(axis) * 4f;

				                if (Input.GetKey(KeyCode.LeftControl) && HSUS.CameraShortcuts.Value)

Shouldn't this divide after multiplying by the correction factor? The way it is now the camera will move even slower in AI/HS2 when everything has a larger scale, so it'll act differently from the KK line of games.

kkykkykky (Migrated from github.com) reviewed

2021-12-28 21:29:58 +00:00

UsefulStuff.Core/Features/CameraShortcuts.cs

					
				@ -63,3 +60,1 @@

				                    return Input.GetAxis(axis) / 6f;

				                if (Input.GetKey(KeyCode.LeftShift))

				                    return Input.GetAxis(axis) * 4f;

				                if (Input.GetKey(KeyCode.LeftControl) && HSUS.CameraShortcuts.Value)

If I just did that, the slow down function would become a speed up function. But I do agree that the camera moves even slower with the larger scale which isn't the expected behavior. Thanks for catching this. This is why you're Manly and I'm just KKY 😁. I guess the underlying issue is that the vanilla camera movement speed in AI/HS2 is 10 times too slow to begin with.

Would this be ok?

            public static float GetCameraMultiplier()
            {
                float _adjDeltaTime = Time.deltaTime * HSUS.CameraMultiplierFactor.Value;
                if (Input.GetKey(KeyCode.LeftControl))
                    return _adjDeltaTime / 6f;
                if (Input.GetKey(KeyCode.LeftShift))
                    return _adjDeltaTime * 4f;
                return _adjDeltaTime;
            }

Maybe I should make the 6f and 4f configurable as well. What do you think?

If I just did that, the slow down function would become a speed up function. But I do agree that the camera moves even slower with the larger scale which isn't the expected behavior. Thanks for catching this. This is why you're Manly and I'm just KKY 😁. I guess the underlying issue is that the vanilla camera movement speed in AI/HS2 is 10 times too slow to begin with. Would this be ok? ```csharp public static float GetCameraMultiplier() { float _adjDeltaTime = Time.deltaTime * HSUS.CameraMultiplierFactor.Value; if (Input.GetKey(KeyCode.LeftControl)) return _adjDeltaTime / 6f; if (Input.GetKey(KeyCode.LeftShift)) return _adjDeltaTime * 4f; return _adjDeltaTime; } ``` Maybe I should make the `6f` and `4f` configurable as well. What do you think?

ManlyMarco (Migrated from github.com) reviewed

2021-12-29 13:16:25 +00:00

UsefulStuff.Core/Features/CameraShortcuts.cs

					
				@ -63,3 +60,1 @@

				                    return Input.GetAxis(axis) / 6f;

				                if (Input.GetKey(KeyCode.LeftShift))

				                    return Input.GetAxis(axis) * 4f;

				                if (Input.GetKey(KeyCode.LeftControl) && HSUS.CameraShortcuts.Value)

I think it's fine.

You could have "FastCamSpeed" and "SlowCamSpeed" settings that replace the constant values (instead of dividing by 6f it should multiply by 0.6f in that case so that both settings have values in the same units).

I think it would make sense to add a hardcoded * 10f to Time.deltaTime * HSUS.CameraMultiplierFactor.Value; for AI/HS2 to not have to have different defaults for the settings (useful for people that play both games, you can copy config files over).

I think it's fine. You could have "FastCamSpeed" and "SlowCamSpeed" settings that replace the constant values (instead of dividing by 6f it should multiply by 0.6f in that case so that both settings have values in the same units). I think it would make sense to add a hardcoded `* 10f` to `Time.deltaTime * HSUS.CameraMultiplierFactor.Value;` for AI/HS2 to not have to have different defaults for the settings (useful for people that play both games, you can copy config files over).

kkykkykky commented

2021-12-30 06:09:55 +00:00

(Migrated from github.com)

Ok. Added configurable CamSpeedFast and CamSpeedSlow. Removed the multiplier from mouse control as it doesn't seem beneficial during my test. Changed when CameraShortcuts value is checked. Also noticed a few config keys were mismatched. Not sure if it's intentional or not. Some of them don't seem to actually do anything at the moment, but I changed them anyway.

👍 1

ManlyMarco (Migrated from github.com) approved these changes

2021-12-30 11:47:45 +00:00

Commenting is not possible because the repository is archived.

No reviewers

ManlyMarco