IllusionMods/HSPlugins
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

[PE] Match OCIItems with their index instead of their order by index #95

Merged
krypto5863 merged 3 commits from main into main 2024-12-11 21:53:32 +00:00
Conversation 6 Commits 3 Files changed 1 +30 -7
krypto5863 commented 2024-12-08 17:46:00 +00:00 (Migrated from github.com)
Copy link

I'm not sure why this was done when a perfectly good index value was available but it gives the plugin room to break, and it did when I made ObjectMap which adds negative values to the dictionary thus causing the order to shift. Hoping this is a good change and I'm not missing something.

Another plugin that I bet does this is Timeline, but I don't really wanna mess with it.

I'm not sure why this was done when a perfectly good index value was available but it gives the plugin room to break, and it did when I made ObjectMap which adds negative values to the dictionary thus causing the order to shift. Hoping this is a good change and I'm not missing something. Another plugin that I bet does this is Timeline, but I don't really wanna mess with it.
ManlyMarco (Migrated from github.com) reviewed 2024-12-08 18:03:43 +00:00
ManlyMarco (Migrated from github.com) left a comment
Copy link

Your whitespace is whack, there's tabs mixed in.

Did you test this on existing old scenes? The more the better.

Your whitespace is whack, there's tabs mixed in. Did you test this on existing old scenes? The more the better.
krypto5863 commented 2024-12-08 18:15:05 +00:00 (Migrated from github.com)
Copy link

I did test on one or two, but I'll do a few more checks real quick.

I did test on one or two, but I'll do a few more checks real quick.
krypto5863 commented 2024-12-08 18:21:39 +00:00 (Migrated from github.com)
Copy link

Checked a good ten scenes in KKS real quick, most not mines. No issues that I can observe.

Checked a good ten scenes in KKS real quick, most not mines. No issues that I can observe.
ManlyMarco (Migrated from github.com) approved these changes 2024-12-11 21:50:44 +00:00
ManlyMarco (Migrated from github.com) left a comment
Copy link

Looks good to me, please make a separate PR for the editor config file.

Looks good to me, please make a separate PR for the editor config file.
ReafLife commented 2024-12-28 00:23:31 +00:00 (Migrated from github.com)
Copy link

If you import another scene when have existing object, imported scene's PE data losted
unknown_2024.12.28-06.17.zip
024-12-28 091935

If you import another scene when have existing object, imported scene's PE data losted [unknown_2024.12.28-06.17.zip](https://github.com/user-attachments/files/18264432/unknown_2024.12.28-06.17.zip) ![024-12-28 091935](https://github.com/user-attachments/assets/7a7118ff-781a-40f9-bf1b-cdaa6bbc4160)
krypto5863 commented 2024-12-28 01:59:12 +00:00 (Migrated from github.com)
Copy link

Oh, I suppose because imported items are being assigned a new key. Interesting challenge. I'll see what I can find.

Oh, I suppose because imported items are being assigned a new key. Interesting challenge. I'll see what I can find.
Sign in to join this conversation.
Reviewers
No reviewers
ManlyMarco
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IllusionMods/HSPlugins!95
No description provided.