IllusionMods/IllusionFixes
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

[KKS][MainGameOptimizations] Increase the maximum number of heroines #67

Closed
takahiro0327 wants to merge 1 commit from add_heroines into master
pull from: add_heroines
merge into: IllusionMods:master
Conversation 7 Commits 1 Files changed 4 +203 -1
takahiro0327 commented 2024-06-16 01:03:40 +00:00 (Migrated from github.com)
Copy link

Added option to increase the number of heroines that can be registered at each inn.

Please review and merge.
This PR was developed with a commission from bitmagnet.

image
image

Added option to increase the number of heroines that can be registered at each inn. Please review and merge. This PR was developed with a commission from bitmagnet. ![image](https://github.com/IllusionMods/IllusionFixes/assets/4230203/44844dae-ed3c-41f9-9ef4-5bd31cc0fcda) ![image](https://github.com/IllusionMods/IllusionFixes/assets/4230203/7801710b-6f44-4bf3-b1b6-87d372803902)
ManlyMarco commented 2024-06-17 12:37:44 +00:00 (Migrated from github.com)
Copy link

For KK, this feature is included in https://github.com/ManlyMarco/KoikatuGameplayMods/?tab=readme-ov-file#koikatu-gameplay-mod

Maybe it would make sense to include this into GameplayMod to keep it in one place? Or maybe split this feature off into a separate plugin.

For KK, this feature is included in https://github.com/ManlyMarco/KoikatuGameplayMods/?tab=readme-ov-file#koikatu-gameplay-mod Maybe it would make sense to include this into GameplayMod to keep it in one place? Or maybe split this feature off into a separate plugin.
ManlyMarco (Migrated from github.com) reviewed 2024-06-17 12:47:38 +00:00
src/KKS_Fix_MainGameOptimizations/AddHeroines.cs
@ -0,0 +14,4 @@
[HarmonyPatch(typeof(ActionGame.ClassRoomList), nameof(ActionGame.ClassRoomList.GetClassRegisterMax))]
static private bool GetClassRegisterMaxPrefix(ActionGame.ClassRoomList __instance, ref int __result, int schoolClass )
{
__result = NewGetClassRegisterMax(schoolClass);
ManlyMarco (Migrated from github.com) commented 2024-06-17 12:40:47 +00:00
Copy link

Why not add AddHeroines.Value to the result in a postfix instead of replacing the whole method?

Why not add `AddHeroines.Value` to the result in a postfix instead of replacing the whole method?
src/KKS_Fix_MainGameOptimizations/MainGameOptimizations.cs
ManlyMarco (Migrated from github.com) commented 2024-06-17 12:44:09 +00:00
Copy link

You can add a ValueChanged event to this setting that immediately removes any heroines above the limit, instead of using the save prefix patch (unless there are other edge cases where the patch is required).

You can add a ValueChanged event to this setting that immediately removes any heroines above the limit, instead of using the save prefix patch (unless there are other edge cases where the patch is required).
takahiro0327 (Migrated from github.com) reviewed 2024-06-17 13:38:01 +00:00
src/KKS_Fix_MainGameOptimizations/MainGameOptimizations.cs
takahiro0327 (Migrated from github.com) commented 2024-06-17 13:38:01 +00:00
Copy link

No. It could be reduced and then increased again. It should be safer not to finalize it until the save.

No. It could be reduced and then increased again. It should be safer not to finalize it until the save.
takahiro0327 (Migrated from github.com) reviewed 2024-06-17 13:38:41 +00:00
src/KKS_Fix_MainGameOptimizations/AddHeroines.cs
@ -0,0 +14,4 @@
[HarmonyPatch(typeof(ActionGame.ClassRoomList), nameof(ActionGame.ClassRoomList.GetClassRegisterMax))]
static private bool GetClassRegisterMaxPrefix(ActionGame.ClassRoomList __instance, ref int __result, int schoolClass )
{
__result = NewGetClassRegisterMax(schoolClass);
takahiro0327 (Migrated from github.com) commented 2024-06-17 13:38:41 +00:00
Copy link

Yes, indeed it is.

Yes, indeed it is.
takahiro0327 commented 2024-06-17 13:46:37 +00:00 (Migrated from github.com)
Copy link

For KK, this feature is included in https://github.com/ManlyMarco/KoikatuGameplayMods/?tab=readme-ov-file#koikatu-gameplay-mod

Maybe it would make sense to include this into GameplayMod to keep it in one place? Or maybe split this feature off into a separate plugin.

OK. porting to KKS_GameplayMod.

> For KK, this feature is included in https://github.com/ManlyMarco/KoikatuGameplayMods/?tab=readme-ov-file#koikatu-gameplay-mod > > Maybe it would make sense to include this into GameplayMod to keep it in one place? Or maybe split this feature off into a separate plugin. OK. porting to KKS_GameplayMod.
takahiro0327 commented 2024-06-17 13:47:14 +00:00 (Migrated from github.com)
Copy link

Thanks for the review.

Thanks for the review.
takahiro0327 (Migrated from github.com) reviewed 2024-06-18 15:29:18 +00:00
src/KKS_Fix_MainGameOptimizations/AddHeroines.cs
@ -0,0 +14,4 @@
[HarmonyPatch(typeof(ActionGame.ClassRoomList), nameof(ActionGame.ClassRoomList.GetClassRegisterMax))]
static private bool GetClassRegisterMaxPrefix(ActionGame.ClassRoomList __instance, ref int __result, int schoolClass )
{
__result = NewGetClassRegisterMax(schoolClass);
takahiro0327 (Migrated from github.com) commented 2024-06-18 15:29:18 +00:00
Copy link

I needed to know the upper limit of the number of people from the patch function. That's why I made it a function. I forgot.

I needed to know the upper limit of the number of people from the patch function. That's why I made it a function. I forgot.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IllusionMods/IllusionFixes!67
No description provided.