Fix_DynamicBones - Fix append particles recursion error #75

Merged
Njaecha merged 4 commits from FixAppendParticlesRecursionError into master 2025-01-14 14:39:07 +00:00
Njaecha commented 2025-01-13 16:15:35 +00:00 (Migrated from github.com)

The return I implemented yesterday would obviously also stop the for loop form adding multiple children like the vanilla code can.
Inspired by the game code, which made adding the leaf require the particle to not have any children, I added a flag so that it can only add a leaf when particle did not add any of its children as particles. This is more similar to game code but also retains the ability to add a leaf particle when all children are in m_Exclusions.

The return I implemented yesterday would obviously also stop the for loop form adding multiple children like the vanilla code can. Inspired by the game code, which made adding the leaf require the particle to not have any children, I added a flag so that it can only add a leaf when particle did not add any of its children as particles. This is more similar to game code but also retains the ability to add a leaf particle when all children are in m_Exclusions.
Njaecha commented 2025-01-13 16:16:41 +00:00 (Migrated from github.com)

I'm sorry that we have to update this code again in such a short time but this forloop in a whileloop in a recursive method got the better of me.

I'm sorry that we have to update this code again in such a short time but this forloop in a whileloop in a recursive method got the better of me.
ManlyMarco (Migrated from github.com) approved these changes 2025-01-14 14:38:29 +00:00
ManlyMarco (Migrated from github.com) left a comment

prayge

prayge
Sign in to join this conversation.
No description provided.