IllusionMods/IllusionLaunchers
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Included a check if the selected language folder have translations. C… #2

Closed
SpockBauru wants to merge 0 commits from master into master
pull from: master
merge into: IllusionMods:master
Conversation 2 Commits - Files changed -
SpockBauru commented 2020-11-19 20:39:27 +00:00 (Migrated from github.com)
Copy link

Included a check if the selected language folder have translation files besides the ones created automatically by XUA (files started with "_" in Text folder). Case positive it doesn't show the google translate message.
Also included a missing text in Portuguese.

Included a check if the selected language folder have translation files besides the ones created automatically by XUA (files started with "_" in Text folder). Case positive it doesn't show the google translate message. Also included a missing text in Portuguese.
ScrewThisNoise (Migrated from github.com) reviewed 2020-11-19 20:39:27 +00:00
ScrewThisNoise commented 2020-11-20 08:36:23 +00:00 (Migrated from github.com)
Copy link

While the edits are sound, they work against the intention of the check. It marks languages not manually translated as machine translations and informs the user of that fact. Intending to add code to disable the check for when a language is 100% hand translated, but none of the supported games are 100% at this point.

While the edits are sound, they work against the intention of the check. It marks languages not manually translated as machine translations and informs the user of that fact. Intending to add code to disable the check for when a language is 100% hand translated, but none of the supported games are 100% at this point.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
ScrewThisNoise
Labels
Clear labels   
ToDo

Going to be addressed

  
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
ToDo
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IllusionMods/IllusionLaunchers!2
No description provided.