Added Manager button to Koikatsu Launcher. #9

Ghost · 2021-08-02T19:33:14Z

ghost commented

2021-08-02 19:33:14 +00:00

(Migrated from github.com)

![image](https://user-images.githubusercontent.com/88344209/127913776-af536bb5-e810-4b11-bbb6-b7b7a41c0944.png)

ManlyMarco (Migrated from github.com) approved these changes

2021-08-02 19:48:42 +00:00

ManlyMarco (Migrated from github.com) left a comment

SeemsGood

Edit: It looks like you don't check if manager exists, you should hide the button if it doesn't exist like it's done with the update button.

SeemsGood Edit: It looks like you don't check if manager exists, you should hide the button if it doesn't exist like it's done with the update button.

ghost commented

2021-08-02 20:24:49 +00:00

(Migrated from github.com)

Fixed missing files.

ManlyMarco (Migrated from github.com) reviewed

2021-08-02 20:47:36 +00:00

src/SharedCode/EnvironmentHelper.cs

					
				@ -698,6 +698,27 @@ namespace InitSetting

				            }

WorkingDirectory = $@"{_kkmanagerDirectory}"

could just be

WorkingDirectory = _kkmanagerDirectory

```cs WorkingDirectory = $@"{_kkmanagerDirectory}" ``` could just be ```cs WorkingDirectory = _kkmanagerDirectory ```

ManlyMarco (Migrated from github.com) reviewed

2021-08-02 20:49:06 +00:00

src/SharedCode/EnvironmentHelper.cs

					
				@ -698,6 +698,27 @@ namespace InitSetting

				            }

Fixed it

Ghost reviewed

2021-08-02 22:02:17 +00:00

src/SharedCode/EnvironmentHelper.cs

					
				@ -698,6 +698,27 @@ namespace InitSetting

				            }

Same can be done on line 692 for updater method.

ScrewThisNoise (Migrated from github.com) approved these changes

2021-08-04 04:08:13 +00:00

Sign in to join this conversation.

No reviewers

ManlyMarco

ScrewThisNoise

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

IllusionMods/IllusionLaunchers!9

Rows
Columns