IllusionMods/IllusionModdingAPI
1
0
Fork 1
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Added dropdowns and colorpickers to the SceneEffectCategory stuff. #77

Merged
krypto5863 merged 6 commits from master into master 2024-09-17 19:41:50 +00:00
Conversation 7 Commits 6 Files changed 6 +453 -5
krypto5863 commented 2024-09-12 17:51:42 +00:00 (Migrated from github.com)
Copy link

Threw these together real quick, I only tested in HS2 and KKS, so lemme know if fixes or changes need to be made.

Threw these together real quick, I only tested in HS2 and KKS, so lemme know if fixes or changes need to be made.
ManlyMarco (Migrated from github.com) requested changes 2024-09-12 21:54:40 +00:00
ManlyMarco (Migrated from github.com) left a comment
Copy link

The changes look good, but whitespace got messed up with random tabs. Make sure your editor is set to using spaces for indents.

The changes look good, but whitespace got messed up with random tabs. Make sure your editor is set to using spaces for indents.
krypto5863 commented 2024-09-12 22:40:29 +00:00 (Migrated from github.com)
Copy link

Should be fixed now, I'm a tab enjoyer. Might add a few more controls to this later.

Should be fixed now, I'm a tab enjoyer. Might add a few more controls to this later.
ManlyMarco commented 2024-09-13 00:23:44 +00:00 (Migrated from github.com)
Copy link

Do you want me to wait with reviewing until you finish adding them? You can mark the PR as a draft in that case.

Do you want me to wait with reviewing until you finish adding them? You can mark the PR as a draft in that case.
krypto5863 commented 2024-09-13 17:50:28 +00:00 (Migrated from github.com)
Copy link

Nah should be good to go now. Think I've done most of the simple stuff with this already.

Nah should be good to go now. Think I've done most of the simple stuff with this already.
ManlyMarco (Migrated from github.com) reviewed 2024-09-17 19:37:41 +00:00
src/Shared.CharaStudio/Studio/UI/SceneEffectsCategory.cs
@ -68,6 +78,13 @@ namespace KKAPI.Studio.UI
#if !PH
ManlyMarco (Migrated from github.com) commented 2024-09-17 19:37:40 +00:00
Copy link

Why not do this?

            var allsprites = Resources.FindObjectsOfTypeAll<Sprite>();
            _expandSprite = allSprites.FirstOrDefault(r => r.name.Equals("sp_sn_09_00_05"));
            _collapseSprite = allSprites.FirstOrDefault(r => r.name.Equals("sp_sn_09_00_03"));
Why not do this? ```suggestion var allsprites = Resources.FindObjectsOfTypeAll<Sprite>(); _expandSprite = allSprites.FirstOrDefault(r => r.name.Equals("sp_sn_09_00_05")); _collapseSprite = allSprites.FirstOrDefault(r => r.name.Equals("sp_sn_09_00_03")); ```
ManlyMarco (Migrated from github.com) reviewed 2024-09-17 19:41:03 +00:00
src/Shared.CharaStudio/Studio/UI/SceneEffectsCategory.cs
@ -68,6 +78,13 @@ namespace KKAPI.Studio.UI
#if !PH
ManlyMarco (Migrated from github.com) commented 2024-09-17 19:41:03 +00:00
Copy link
            var allSprites = Resources.FindObjectsOfTypeAll<Sprite>();
```suggestion var allSprites = Resources.FindObjectsOfTypeAll<Sprite>(); ```
ManlyMarco (Migrated from github.com) approved these changes 2024-09-17 19:41:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ManlyMarco
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IllusionMods/IllusionModdingAPI!77
No description provided.