[MainGameVR] POV addition #48

2024-10-23T17:08:28Z

metabusdriver21 commented

2024-10-23 17:08:28 +00:00

(Migrated from github.com)

This should unnecessitate the PR #46 and #47 to be reviewed.
I checked the diff between the curren HEAD and tony246642:master, POV related changes only lived inside the recent two commits.
a45f616 includes most of the implementation and I had to redo/simplify the logics, removing some of math/reason which I thought was not the best for me.
Since much of divergence between KKS_VR and KK_MainGameVR is of path-changes as well as submodule packaging, rebasing the whole thing will basically require >10x more effort whereas what we want is to simply putting POV.

How to test

once in H-scene after launching KoikatsuSunshine.exe --vr
trigger button on Hand menu will enable POV
if there is another male in the scene, each trigger will change POV target one by one

This should unnecessitate the PR #46 and #47 to be reviewed. I checked the diff between the curren HEAD and [tony246642:master](https://github.com/tony246642/KK_MainGameVR/tree/master), POV related changes only lived inside the recent two commits. [a45f616](https://github.com/IllusionMods/KKS_VR/pull/47/commits/a45f6166adbee753ccad3b1086d6aadbfd3e2b83) includes most of the implementation and I had to redo/simplify the logics, removing some of math/reason which I thought was not the best for me. Since much of divergence between [KKS_VR](https://github.com/IllusionMods/KKS_VR) and [KK_MainGameVR](https://github.com/tony246642/KK_MainGameVR) is of path-changes as well as submodule packaging, rebasing the whole thing will basically require >10x more effort whereas what we want is to simply putting POV. How to test - once in H-scene after launching `KoikatsuSunshine.exe --vr` - trigger button on Hand menu will enable POV - if there is another male in the scene, each trigger will change POV target one by one

👍 1

metabusdriver21 (Migrated from github.com) reviewed

2024-10-23 17:14:52 +00:00

MainGameVR/Camera/POV.cs

					
				@ -0,0 +1,157 @@

				﻿using System;

Mode3 to Mode2

ManlyMarco commented

2024-10-23 18:57:15 +00:00

(Migrated from github.com)

Thanks for the PR, I'll review it later.

One upside of merging upstream and the fork would be easier merging of any future fixes, but it definitely is a mess to do.

Thanks for the PR, I'll review it later. One upside of merging upstream and the fork would be easier merging of any future fixes, but it definitely is a mess to do.

🚀 1

ManlyMarco (Migrated from github.com) approved these changes

2024-10-24 21:15:52 +00:00

ManlyMarco commented

2024-10-28 00:25:23 +00:00

(Migrated from github.com)

I went through the merge conflicts and managed to make it build #49

I posted a build here if you'd like to give it a try #44, theoretically it should fix mirrors and some other stuff.

I went through the merge conflicts and managed to make it build #49 I posted a build here if you'd like to give it a try #44, theoretically it should fix mirrors and some other stuff.

Clo363 commented

2024-10-31 00:51:44 +00:00

(Migrated from github.com)

Sadly mirrors are not fixed in studio (v1.5) . The right eye shows correct image, the left eye shows distorted image. Also messes up other reflective surfaces (e.g. liquids).

Sign in to join this conversation.

No reviewers

ManlyMarco