IllusionMods/KeelPlugins
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix KK version of ClothingStateMenuX attempting to hook KKS version of MoreOutfits assembly #47

Merged
Kokaiinum merged 1 commit from master into master 2024-12-20 11:42:39 +00:00
Conversation 5 Commits 1 Files changed 1 +4
Kokaiinum commented 2024-12-19 21:56:41 +00:00 (Migrated from github.com)
Copy link
No description provided.
ManlyMarco (Migrated from github.com) reviewed 2024-12-19 22:41:27 +00:00
ManlyMarco (Migrated from github.com) left a comment
Copy link

Why not do an #if KK on the HarmonyPatch attribute instead? Seems far simpler than this.

Why not do an `#if KK` on the HarmonyPatch attribute instead? Seems far simpler than this.
Kokaiinum commented 2024-12-19 22:56:18 +00:00 (Migrated from github.com)
Copy link

In hindsight, yes. Added this change.

In hindsight, yes. Added this change.
Keelhauled commented 2024-12-19 23:19:07 +00:00 (Migrated from github.com)
Copy link

Are the .sln changes necessary? Also move the brackets to their own lines.

Are the .sln changes necessary? Also move the brackets to their own lines.
Kokaiinum commented 2024-12-19 23:49:44 +00:00 (Migrated from github.com)
Copy link

The .sln changes were done automatically by VS, I didn't touch that. So they're probably not neccessary? I can revert them if you prefer

The .sln changes were done automatically by VS, I didn't touch that. So they're probably not neccessary? I can revert them if you prefer
Keelhauled commented 2024-12-19 23:58:08 +00:00 (Migrated from github.com)
Copy link

It's pretty easy to pick just what actually needs to be committed with git. I assume it's just that HarmonyPostfix change so about 5 lines.

It's pretty easy to pick just what actually needs to be committed with git. I assume it's just that HarmonyPostfix change so about 5 lines.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IllusionMods/KeelPlugins!47
No description provided.