Shoe warp: fix communication #10

Merged

Splendide-Imaginarius merged 1 commit from communication into master

2023-08-18 00:33:43 +00:00

Splendide-Imaginarius commented

2023-08-16 12:40:05 +00:00

(Migrated from github.com)

Let me know if you think the performance impact of this fix is problematic; I suspect it would be possible to cache the warped matrix in the same way that we cache the base matrix (but without concurrency), which would probably speed things up a bit if needed.

Upon entering a Communication scene, the shoe state was getting reset sufficiently to wipe out the changes we made to the bind poses, but not sufficiently to cause our dirty flag to get set. The animation state does get reset in this case, so we can reuse that detection to avoid breakage without having to recalculate every frame. Let me know if you think the performance impact of this fix is problematic; I suspect it would be possible to cache the warped matrix in the same way that we cache the base matrix (but without concurrency), which would probably speed things up a bit if needed.

ManlyMarco (Migrated from github.com) approved these changes

2023-08-18 00:33:29 +00:00

ManlyMarco (Migrated from github.com) left a comment

It's probably fine but it could cause a larger hitch when animation is changing. Either way, the fix is good so I'll merge it. Thanks!