IllusionMods/Stiletto
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Add shoe warp #8

Merged
Splendide-Imaginarius merged 2 commits from shoe-warp into master 2023-07-26 21:59:11 +00:00
Conversation 5 Commits 2 Files changed 5 +355
Splendide-Imaginarius commented 2023-07-01 14:08:52 +00:00 (Migrated from github.com)
Copy link

Useful for tweaking the dimensions/shape of shoes.

Only accessible from Maker GUI for now.

Useful for tweaking the dimensions/shape of shoes. Only accessible from Maker GUI for now.
ManlyMarco (Migrated from github.com) requested changes 2023-07-02 12:12:35 +00:00
ManlyMarco (Migrated from github.com) left a comment
Copy link

The code looks good to me as far as functionality goes, although it looks like performance can be a problem.

The code looks good to me as far as functionality goes, although it looks like performance can be a problem.
Stiletto/HeelInfo.cs
ManlyMarco (Migrated from github.com) commented 2023-07-02 12:11:31 +00:00
Copy link

This is fairly expensive to run on every frame. At the very least check if user changed any of the transform properties and don't run this code if not.

This is fairly expensive to run on every frame. At the very least check if user changed any of the transform properties and don't run this code if not.
Splendide-Imaginarius (Migrated from github.com) reviewed 2023-07-02 19:36:33 +00:00
Stiletto/HeelInfo.cs
Splendide-Imaginarius (Migrated from github.com) commented 2023-07-02 19:36:33 +00:00
Copy link

Good point, thanks for noticing that. I'll see if I can optimize that a bit.

Good point, thanks for noticing that. I'll see if I can optimize that a bit.
Splendide-Imaginarius (Migrated from github.com) reviewed 2023-07-26 20:44:23 +00:00
Stiletto/HeelInfo.cs
Splendide-Imaginarius (Migrated from github.com) commented 2023-07-26 20:44:23 +00:00
Copy link

Hopefully better now?

Hopefully better now?
ManlyMarco (Migrated from github.com) approved these changes 2023-07-26 21:58:05 +00:00
ManlyMarco (Migrated from github.com) reviewed 2023-07-26 21:58:22 +00:00
Stiletto/HeelInfo.cs
ManlyMarco (Migrated from github.com) commented 2023-07-26 21:58:22 +00:00
Copy link

Yeah, that works, thanks.

Yeah, that works, thanks.
Sign in to join this conversation.
Reviewers
No reviewers
ManlyMarco
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IllusionMods/Stiletto!8
No description provided.