More logging, render statistics and improvements #3

Merged

SangMan_LINUX merged 2 commits from Lusio/HSPlugins:feature/ISSUE-1-The-recording-method-is-very-inefficient into feature/ISSUE-1-The-recording-method-is-very-inefficient

2025-12-25 17:24:58 +00:00

Lusio commented

2025-12-25 16:47:47 +00:00

Contributor

No description provided.

Lusio added 1 commit

2025-12-25 16:47:47 +00:00

Only start FFmpeg master thread if we will actually use it. 88c6d54cfe

Moved plugin, currentSIze and targetSize outside so we can reuse it.
We are now logging start frame capture with stats about the capture.
Added warnings for not returned textures from screenshot plugins.
Removed duplicate log for screenshot and video creation since it printed the same time.
We are now logging stats about the render after its completion in both async and sync mode.
Don't try to delete the frame directory if _autoGenerateVideo is false.
Adedd a function to display padded tables in console.

Lusio changed title from ~~More logging for warnings about missing framedata and stats for video generation~~ to More logging, render statistics and improvements

2025-12-25 16:50:06 +00:00

SangMan_LINUX approved these changes

2025-12-25 17:01:25 +00:00

Dismissed

SangMan_LINUX left a comment

Owner

Hello there,

Thank you for your PR.

After reviewing, this appears to eliminate redundant logging and implement consistent, concise logging functionality.

In addition, the branching part that was lacking in the existing algorithm has been well improved.

We don't think there are any particular problems.

Sincerely,

Hello there, Thank you for your PR. After reviewing, this appears to eliminate redundant logging and implement consistent, concise logging functionality. In addition, the branching part that was lacking in the existing algorithm has been well improved. We don't think there are any particular problems. Sincerely,

Lusio added 1 commit

2025-12-25 17:14:38 +00:00

Fixed a bug that prevented recordings without limits to show proper frame stats. 7f7fbbaa1c

SangMan_LINUX approved these changes

2025-12-25 17:23:38 +00:00

SangMan_LINUX left a comment

Owner

Hello there,

Thank you for your additional commit.

It looks like a part that has been meticulously handled for exceptions.

We don't think there are any particular problems.

Sincerely,

Hello there, Thank you for your additional commit. It looks like a part that has been meticulously handled for exceptions. We don't think there are any particular problems. Sincerely,