Downgrade minSdkVersion, adding babel & polyfilling support, css polifilling, engine routine modification #5

Closed

yl12053 wants to merge 0 commits from master into master

yl12053 commented

2024-12-20 10:59:41 +00:00

(Migrated from gitgud.io)

This merge request attempts to lower sdkVersion to:

minSdkVersion 22 (Android 5.1)
compileSdkVersion 34 (Android 14)
targetSdkVersion 34

It also polyfills missing JavaScript functions using core-js and compiles ECMAScript6 syntax to ECMAScript5, including:

Nullish coalescing operator
Optional chaining
Logical AND/OR assignment

However, due to the outdated WebView bundled with Android 5.1 (Chromium 39.0.0) which doesn't support many features, and also behaves very differently from modern browser, there is currently impossible to run such project on Android 5.1 unless an webview implementation (i.e. Chromium, Firefox, etc.) is bundled with app.

For browsers that doesn't support css property color-scheme, a polyfill is provided in main.js by detecting if window.getComputedStyle(document.querySelector("body"))['color-scheme'] is undefined or not

Note: The old merge request is trashed. This merge request will no longer call @babel/cli for compiling bundled resources, but uses @vitejs/plugin-legacy to auto compile when bundling.

Engine Routine This merge requests changes the behaviour of engine when the game is going to quit. Now, the engine shall no longer raise new Error("quit");. instead the engine shall raise new QuitException();, such changes can prevent any arbitery error class with content "quit" being accidentally raised, and the engine captures hence treated as quit request.
Now, engine catchs such error would lead to an instant termination of the app. In order to have a mild solution, App.exitApp(); could be changed into window.location.reload();

This merge request attempts to lower sdkVersion to: - minSdkVersion 22 (Android 5.1) - compileSdkVersion 34 (Android 14) - targetSdkVersion 34 It also polyfills missing JavaScript functions using core-js and compiles ECMAScript6 syntax to ECMAScript5, including: - Nullish coalescing operator - Optional chaining - Logical AND/OR assignment However, due to the outdated WebView bundled with Android 5.1 (Chromium 39.0.0) which doesn't support many features, and also behaves very differently from modern browser, there is currently impossible to run such project on Android 5.1 unless an webview implementation (i.e. Chromium, Firefox, etc.) is bundled with app. For browsers that doesn't support css property `color-scheme`, a polyfill is provided in main.js by detecting if `window.getComputedStyle(document.querySelector("body"))['color-scheme']` is `undefined` or not **Note:** The old merge request is trashed. This merge request will no longer call @babel/cli for compiling bundled resources, but uses @vitejs/plugin-legacy to auto compile when bundling. **Engine Routine** This merge requests changes the behaviour of engine when the game is going to quit. Now, the engine shall no longer raise `new Error("quit");`. instead the engine shall raise `new QuitException();`, such changes can prevent any arbitery error class with content "quit" being accidentally raised, and the engine captures hence treated as quit request. Now, engine catchs such error would lead to an instant termination of the app. In order to have a mild solution, `App.exitApp();` could be changed into `window.location.reload();`

SLeader commented

2024-12-20 11:01:12 +00:00

(Migrated from gitgud.io)

requested review from @SLeader

SLeader (Migrated from gitgud.io) closed this pull request

2024-12-20 11:46:43 +00:00